From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <ak@muc.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH] Support compat_ioctl for block devices
Date: Tue, 18 Jan 2005 09:19:27 +0000 [thread overview]
Message-ID: <20050118091927.GA24768@infradead.org> (raw)
In-Reply-To: <20050118075602.GD76018@muc.de>
> +long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
> +{
> + struct block_device *bdev = file->f_dentry->d_inode->i_bdev;
> + struct gendisk *disk = bdev->bd_disk;
> + int ret = -ENOIOCTLCMD;
> + if (disk->fops->compat_ioctl) {
> + lock_kernel();
> + ret = disk->fops->compat_ioctl(file, cmd, arg);
> + unlock_kernel();
> + }
> + return ret;
> +}
- please don't introduce a new API with the BKL held.
- prototype isn't nice. just passing the gendisk for block_device
should be enough.
also this wants documentation in Documentation/filesystems/Locking
next prev parent reply other threads:[~2005-01-18 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 7:56 [PATCH] Support compat_ioctl for block devices Andi Kleen
2005-01-18 9:19 ` Christoph Hellwig [this message]
2005-01-18 9:31 ` Andi Kleen
2005-01-18 9:36 ` Christoph Hellwig
2005-01-18 9:51 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118091927.GA24768@infradead.org \
--to=hch@infradead.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.