From: Andi Kleen <ak@muc.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@SteelEye.com, Kai.Makisara@kolumbus.fi,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Add compat_ioctl to st
Date: 18 Jan 2005 13:30:24 +0100
Date: Tue, 18 Jan 2005 13:30:24 +0100 [thread overview]
Message-ID: <20050118123024.GA68224@muc.de> (raw)
In-Reply-To: <20050118122524.GN30982@parcelfarce.linux.theplanet.co.uk>
> How about having a macro ...
>
> .ioctl = st_ioctl,
> COMPAT_IOCTL_ENTRY(st_compat_ioctl)
> .open = st_open,
>
> which could be defined something like:
>
> #ifdef CONFIG_COMPAT
> #define COMPAT_IOCTL_ENTRY(x) .compat_ioctl = x,
> #else
> #define COMPAT_IOCTL_ENTRY(x) /* */
> #endif
To be honest I prefer the ifdef. It makes it clear
what is going on, without any unneeded abstraction.
The macro in comparison looks unnatural in the definition
block.
-Andi
next prev parent reply other threads:[~2005-01-18 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 11:06 [PATCH] Add compat_ioctl to st Andi Kleen
2005-01-18 11:23 ` Christoph Hellwig
2005-01-18 11:26 ` Andi Kleen
2005-01-18 12:25 ` Matthew Wilcox
2005-01-18 12:30 ` Andi Kleen [this message]
2005-01-18 12:54 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118123024.GA68224@muc.de \
--to=ak@muc.de \
--cc=James.Bottomley@SteelEye.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.