From: "David S. Miller" <davem@davemloft.net>
To: Dave Peterson <dsp@llnl.gov>
Cc: Robert.Olsson@data.slu.se, robert.olsson@its.uu.se, netdev@oss.sgi.com
Subject: Re: possible bug in net/core/pktgen.c (2.6.10 kernel)
Date: Tue, 18 Jan 2005 12:41:00 -0800 [thread overview]
Message-ID: <20050118124100.17b7f47a.davem@davemloft.net> (raw)
In-Reply-To: <200501180935.25419.dsp@llnl.gov>
On Tue, 18 Jan 2005 09:35:25 -0800
Dave Peterson <dsp@llnl.gov> wrote:
> On Sunday 16 January 2005 04:46 am, Robert Olsson wrote:
> > Dave Peterson writes:
> > > I found a piece of code that looks problematic in the 2.6.10 kernel.
> > > The following code appears starting on line 746 in function inject()
> > > of net/core/pktgen.c:
> > > schedule();
> > > else
> > > do_softirq();
> >
> > Thanks!
> > So it should be?
>
> Cool! Looks like a fix to me.
I'm still a little bit confused on this one.
Since when does do_softirq() need preemption disabled
around calls to it?
do_softirq() disabled hard IRQs during the duration of it's
execution, thus effectively disabling preemption.
What is the problematic case again?
next prev parent reply other threads:[~2005-01-18 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 19:29 possible bug in net/core/pktgen.c (2.6.10 kernel) Dave Peterson
2005-01-16 12:46 ` Robert Olsson
2005-01-18 17:35 ` Dave Peterson
2005-01-18 20:41 ` David S. Miller [this message]
2005-01-18 21:46 ` Dave Peterson
2005-01-18 21:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050118124100.17b7f47a.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=dsp@llnl.gov \
--cc=netdev@oss.sgi.com \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.