All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value
Date: Wed, 19 Jan 2005 10:53:22 +0000	[thread overview]
Message-ID: <20050119105321.GI19162@nd47.coderock.org> (raw)
In-Reply-To: <1106126053.13875.59.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On 19/01/05 14:44 +0530, Amit Gud wrote:
> Description: The patch follows from the suggestions by AC and Felipe W
> Damasio for fixing the return codes from IDE drivers.
> 
> Do consider applying.
> 
> 
> Signed-off-by: Amit Gud <gud@eth.net>
> 
> --- vanilla-2.6.10/drivers/ide/pci/cs5520.c     2005-01-19
> 11:19:28.000000000 +0530

Line wrap. (Turn this off in your mailer)

> +++ linux-2.6.9/drivers/ide/pci/cs5520.c        2005-01-19
> 14:23:50.000000000 +0530
> @@ -224,7 +224,7 @@
>         if(pci_enable_device_bars(dev, 1<<2))
	
Whitespace damage.
(Don't copy/paste. Try mailing patch to yourself first, and see if it
 applies)

>         {
>                 printk(KERN_WARNING "%s: Unable to enable 55x0.\n",
> d->name);
> -               return 1;
> +               return -EAGAIN;

-EAGAIN? -ENODEV, like it's a few lines below looks more apropriate.


>         }
>         pci_set_master(dev);
>         if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {
> 
> 

Wrt. generic.c patch... is seems already merged.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-01-19 10:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19  9:26 [KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value Amit Gud
2005-01-19 10:53 ` Domen Puncer [this message]
2005-01-19 14:52 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050119105321.GI19162@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.