From: Greg KH <greg@kroah.com>
To: Ed L Cashin <ecashin@coraid.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AOE: fix up the block device registration so that it actually works now.
Date: Wed, 19 Jan 2005 13:56:20 -0800 [thread overview]
Message-ID: <20050119215620.GF4151@kroah.com> (raw)
In-Reply-To: <87llap5x69.fsf@coraid.com>
On Wed, Jan 19, 2005 at 09:08:14AM -0500, Ed L Cashin wrote:
> > diff -Nru a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> > --- a/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> > +++ b/drivers/block/aoe/aoeblk.c 2005-01-18 16:06:57 -08:00
> > @@ -249,6 +249,7 @@
> > aoeblk_exit(void)
> > {
> > kmem_cache_destroy(buf_pool_cache);
> > + unregister_blkdev(AOE_MAJOR, DEVICE_NAME);
> > }
>
> The unregister_blkdev should already be in aoemain.c:aoe_exit.
Why? You do a register_blockdev() in this file, so if something fails,
you should also unregister here. The big problem is you were trying to
register the same major twice :(
thanks,
greg k-h
next prev parent reply other threads:[~2005-01-19 22:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 0:09 [PATCH] AOE: fix up the block device registration so that it actually works now Greg KH
2005-01-19 14:08 ` Ed L Cashin
2005-01-19 21:56 ` Greg KH [this message]
2005-01-20 13:35 ` Ed L Cashin
2005-01-20 14:43 ` Greg KH
2005-01-19 20:43 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050119215620.GF4151@kroah.com \
--to=greg@kroah.com \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.