All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	jejb@steeleye.com, James.Smart@Emulex.Com,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drop some attibutes from the FC transport class
Date: Thu, 20 Jan 2005 06:41:34 -0800	[thread overview]
Message-ID: <20050120144134.GA13036@kroah.com> (raw)
In-Reply-To: <20050120051200.GA20064@lists.us.dell.com>

On Wed, Jan 19, 2005 at 11:12:00PM -0600, Matt Domsch wrote:
> On Wed, Jan 19, 2005 at 03:42:19PM -0800, Greg KH wrote:
> > Here it was against 2.6.9.  Odds are it doesn't apply anymore due to
> > some recent changes in this area.  If anyone wants to take it and fix it
> > up, please do so.
> > 
> > Note, this patch needs the evil strdup() function to work properly.
> > That's one of the main reasons I decided to not submit it to the main
> > kernel tree...
> 
> How would you feel if instead, we just didn't drop the .modinfo
> section?  That would eliminate the need to copy the strings, and then
> the field##_get_function would just use the string from the .modinfo
> section directly?

That makes sense to me, but you might want to ask Rusty about it, as
it's his code.

thanks,

greg k-h

  reply	other threads:[~2005-01-20 14:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-19 17:13 [PATCH] drop some attibutes from the FC transport class Christoph Hellwig
2005-01-19 17:21 ` Greg KH
2005-01-19 18:38   ` Brian King
2005-01-19 18:45     ` Greg KH
2005-01-19 22:59       ` Brian King
2005-01-19 21:39   ` Mike Anderson
2005-01-19 22:40     ` Greg KH
2005-01-19 23:03       ` Brian King
2005-01-19 23:03       ` Christoph Hellwig
2005-01-19 23:08         ` Greg KH
2005-01-19 23:15           ` Matt Domsch
2005-01-19 23:42             ` Greg KH
2005-01-20  5:12               ` Matt Domsch
2005-01-20 14:41                 ` Greg KH [this message]
2005-01-26  6:05               ` [PATCH 2.6.11-rc2] modules: add version and srcversion to sysfs Matt Domsch
2005-01-26  9:22                 ` Andreas Gruenbacher
2005-01-26 14:09                   ` Matt Domsch
2005-01-26 16:38                     ` Andreas Gruenbacher
2005-01-27 17:03                       ` Matt Domsch
2005-01-27 17:41                       ` Bill Davidsen
2005-01-26 14:32                 ` Paulo Marques
2005-01-27  2:10                   ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2005-01-19 17:25 [PATCH] drop some attibutes from the FC transport class James.Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050120144134.GA13036@kroah.com \
    --to=greg@kroah.com \
    --cc=James.Smart@Emulex.Com \
    --cc=Matt_Domsch@dell.com \
    --cc=hch@infradead.org \
    --cc=jejb@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.