From: "David S. Miller" <davem@davemloft.net>
To: "Michael Chan" <mchan@broadcom.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.10] tg3: add tg3_set_eeprom
Date: Thu, 20 Jan 2005 15:05:19 -0800 [thread overview]
Message-ID: <20050120150519.08ef54fa.davem@davemloft.net> (raw)
In-Reply-To: <B1508D50A0692F42B217C22C02D84972020F3D2E@NT-IRVA-0741.brcm.ad.broadcom.com>
On Thu, 20 Jan 2005 14:52:14 -0800
"Michael Chan" <mchan@broadcom.com> wrote:
> Add tg3_set_eeprom routine to support configuration changes (e.g. ASF
> config).
>
> Made changes to other nvram related routines.
Why were the NVRAM_ACCESS writes change to non-flushing register
writes? Otherwise I think your patch is fine.
Maybe it would be nice if you provided a detailed changelog
of sorts, because other's might have similar questions like I
did about why the tw32_f() --> tw32() changes were made.
next prev parent reply other threads:[~2005-01-20 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 22:52 [PATCH 2.6.10] tg3: add tg3_set_eeprom Michael Chan
2005-01-20 23:05 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-21 0:00 Michael Chan
2005-01-21 0:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050120150519.08ef54fa.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.