From: Amit Gud <amitg@calsoftinc.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] unified spinlock initialization
Date: Thu, 20 Jan 2005 15:36:46 +0000 [thread overview]
Message-ID: <200501202054.49099.amitg@calsoftinc.com> (raw)
In-Reply-To: <20050120153602.GI25940@parcelfarce.linux.theplanet.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]
Unify the spinlock initialization as far as possible.
Do consider applying.
Signed-off-by: Amit Gud <gud@eth.net>
--- vanilla-2.6.10/arch/um/drivers/net_kern.c 2005-01-19 11:19:23.000000000 +0530
+++ linux-2.6.10/arch/um/drivers/net_kern.c 2005-01-20 20:28:31.000000000 +0530
@@ -30,7 +30,7 @@
#include "irq_user.h"
#include "irq_kern.h"
-static spinlock_t opened_lock = SPIN_LOCK_UNLOCKED;
+static spinlock_t opened_lock;
LIST_HEAD(opened);
static int uml_net_rx(struct net_device *dev)
@@ -286,7 +286,7 @@ void uml_net_user_timer_expire(unsigned
#endif
}
-static spinlock_t devices_lock = SPIN_LOCK_UNLOCKED;
+static spinlock_t devices_lock;
static struct list_head devices = LIST_HEAD_INIT(devices);
static int eth_configure(int n, void *init, char *mac,
@@ -371,7 +371,6 @@ static int eth_configure(int n, void *in
save = lp->user[0];
*lp = ((struct uml_net_private)
{ .list = LIST_HEAD_INIT(lp->list),
- .lock = SPIN_LOCK_UNLOCKED,
.dev = dev,
.fd = -1,
.mac = { 0xfe, 0xfd, 0x0, 0x0, 0x0, 0x0},
@@ -387,6 +386,7 @@ static int eth_configure(int n, void *in
.set_mtu = transport->user->set_mtu,
.user = { save } });
+ spin_lock_init(&lp->lock);
init_timer(&lp->tl);
lp->tl.function = uml_net_user_timer_expire;
if (lp->have_mac)
@@ -679,6 +679,8 @@ static int uml_net_init(void)
struct in_device *ip;
struct in_ifaddr *in;
+ spin_lock_init(&opened_lock);
+ spin_lock_init(&devices_lock);
mconsole_register_dev(&net_mc);
register_inetaddr_notifier(¨_inetaddr_notifier);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-01-20 15:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 15:36 [KJ] [PATCH] unified spinlock initialization Matthew Wilcox
2005-01-20 15:36 ` Amit Gud [this message]
2005-01-20 15:38 ` Amit Gud
2005-01-20 15:39 ` Amit Gud
2005-01-20 15:40 ` Amit Gud
2005-01-24 15:28 ` [KJ] [PATCH] unified spinlock initialization drivers/acpi/ec.c Amit Gud
2005-01-24 15:30 ` [KJ] [PATCH] unified spinlock initialization Amit Gud
2005-01-24 15:41 ` [KJ] [PATCH] unified spinlock initialization drivers/block/DAC960.c Amit Gud
2005-01-24 15:42 ` [KJ] [PATCH] unified spinlock initialization Amit Gud
2005-01-24 15:48 ` Amit Gud
2005-01-24 16:11 ` Randy.Dunlap
2005-01-24 16:25 ` Christophe Lucas
2005-01-24 16:41 ` Domen Puncer
2005-01-25 7:03 ` Christophe Lucas
2005-01-25 7:07 ` [KJ] [PATCH] Unified " Christophe Lucas
2005-01-25 11:33 ` Amit Gud
-- strict thread matches above, loose matches on Subject: below --
2005-01-25 11:34 [PATCH] unified spinlock initialization arch/mips/kernel/irq.c Amit Gud
2005-01-25 11:46 ` [KJ] " Amit Gud
2005-01-25 13:43 ` [KJ] [PATCH] unified spinlock initialization Matthew Wilcox
2005-01-25 13:43 ` [KJ] [PATCH] unified spinlock initialization arch/mips/kernel/irq.c Matthew Wilcox
2005-01-25 11:35 [PATCH] Unified spinlock initialization include/linux/wait.h Amit Gud
2005-01-25 11:47 ` [KJ] " Amit Gud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501202054.49099.amitg@calsoftinc.com \
--to=amitg@calsoftinc.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.