All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [patch 2.4.29] i810_audio: offset LVI from CIV to avoid stalled start
Date: Thu, 20 Jan 2005 17:01:21 -0500	[thread overview]
Message-ID: <20050120220120.GF7687@tuxdriver.com> (raw)
In-Reply-To: <20050120212346.GD7687@tuxdriver.com>

On Thu, Jan 20, 2005 at 04:23:46PM -0500, John W. Linville wrote:

> +	/* if we are currently stopped, then our CIV is actually set to our
> +	 * *last* sg segment and we are ready to wrap to the next.  However,
> +	 * if we set our LVI to the last sg segment, then it won't wrap to
> +	 * the next sg segment, it won't even get a start.  So, instead, when
> +	 * we are stopped, we increment the CIV value to the next sg segment
> +	 * to be played so that when we call start, things will operate
> +	 * properly
> +	 */

Herbert,

Is this (slightly altered) comment more to your liking?  If so,
I'll post an additive patch for the 2.6 version...

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2005-01-20 22:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-20 20:22 [patch 2.4.29] i810_audio: offset LVI from CIV to avoid stalled start John W. Linville
2005-01-20 20:27 ` Herbert Xu
2005-01-20 21:07 ` John W. Linville
2005-01-20 21:23   ` John W. Linville
2005-01-20 22:01     ` John W. Linville [this message]
2005-01-20 22:07       ` Herbert Xu
2005-01-22  3:02         ` Herbert Xu
2005-01-23 14:48           ` John W. Linville
2005-01-23 14:54     ` John W. Linville
2005-08-03 18:18     ` [patch 2.4.32-pre1] " John W. Linville
2005-08-03 18:35       ` John W. Linville
2005-08-03 18:36       ` [patch 2.4.32-pre1 (corrected)] " John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050120220120.GF7687@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.