From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1CsJiu-000186-KC for mharc-grub-devel@gnu.org; Sat, 22 Jan 2005 06:46:36 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CsJip-000169-0n for grub-devel@gnu.org; Sat, 22 Jan 2005 06:46:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CsJim-000155-3r for grub-devel@gnu.org; Sat, 22 Jan 2005 06:46:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CsJil-00013R-Vc for grub-devel@gnu.org; Sat, 22 Jan 2005 06:46:28 -0500 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CsJPZ-0001Wn-VI for grub-devel@gnu.org; Sat, 22 Jan 2005 06:26:38 -0500 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 36657F8DFBE1 for ; Sat, 22 Jan 2005 12:25:57 +0100 (CET) Received: from 127.0.0.1 ([127.0.0.1] helo=localhost) by ASSP-nospam ; 22 Jan 05 11:25:55 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 22 Jan 2005 12:26:19 +0100 User-Agent: KMail/1.7.1 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200501221226.19592.okuji@enbug.org> Subject: Re: iterate return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2005 11:46:31 -0000 On Saturday 22 January 2005 07:57, Hollis Blanchard wrote: > When a hook is passed to grub_partition_iterate, it is applied to > partmap->iterate. However, the partition map's iterate functions can > return non-zero in case of error (such as "not a PC partition map"). > Non-zero is then propagated back to grub_partition_map_iterate, and > the iteration stops. In that case we should clearly keep going to try > another partition map type. It's a big problem. I think grub_partition_iterate should not return non-zero when it fails. Okuji