From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 1/2] acorn: clean up printk()'s in
Date: Sat, 22 Jan 2005 18:50:47 +0000 [thread overview]
Message-ID: <20050122185047.GB28104@nd47.coderock.org> (raw)
In-Reply-To: <20050121010751.18138.42311.24615@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On 20/01/05 19:07 -0600, James Nelson wrote:
> Signed-off-by: James Nelson <james4765@gmail.com>
>
ENODESC
> diff -urN --exclude='*~' linux-2.6.11-rc1-mm2-original/drivers/acorn/block/fd1772.c linux-2.6.11-rc1-mm2/drivers/acorn/block/fd1772.c
> --- linux-2.6.11-rc1-mm2-original/drivers/acorn/block/fd1772.c 2005-01-20 16:33:13.000000000 -0500
> +++ linux-2.6.11-rc1-mm2/drivers/acorn/block/fd1772.c 2005-01-20 19:56:54.542776654 -0500
> @@ -180,6 +175,13 @@
> #define DEVICE_NAME "floppy"
> #define QUEUE (floppy_queue)
> #define CURRENT elv_next_request(floppy_queue)
> +#define PFX DEVICE_NAME ": "
> +
> +#ifdef DEBUG
> +#define DBG(fmt, args...) pr_debug(PFX "%s(): " fmt, __FUNCTION__ , ## args)
> +#else
> +#define DBG(fmt, args...)
> +#endif
This #ifdef is not needed.
> @@ -1418,14 +1419,15 @@
> {
> int drive, cnt = 0;
>
> - printk("Probing floppy drive(s):\n");
> + pr_info("Probing floppy drive(s):);
^^
Missing ".
Was this compile tested?
Domen
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-01-22 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-21 1:07 [KJ] [PATCH 1/2] acorn: clean up printk()'s in James Nelson
2005-01-22 18:50 ` Domen Puncer [this message]
2005-01-23 0:54 ` [KJ] [PATCH 1/2] acorn: clean up printk()'s Jim Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050122185047.GB28104@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.