From: Matthew Wilcox <matthew@wil.cx>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] zfcp: updates for -bk
Date: Mon, 24 Jan 2005 14:22:45 +0000 [thread overview]
Message-ID: <20050124142245.GJ31455@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050124094629.GA9404@osiris.boeblingen.de.ibm.com>
On Mon, Jan 24, 2005 at 10:46:29AM +0100, Heiko Carstens wrote:
> @@ -1099,9 +1099,9 @@
> }
>
> void
> -zfcp_dummy_release(struct device *dev)
> +zfcp_generic_services_release(struct device *dev)
> {
> - return;
> + kfree(dev);
> }
>
> /*
I thought that having release methods that just called kfree() were
also verboten?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2005-01-24 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 9:46 [PATCH] zfcp: updates for -bk Heiko Carstens
2005-01-24 14:22 ` Matthew Wilcox [this message]
2005-01-24 14:48 ` Heiko Carstens
2005-01-24 15:31 ` James Bottomley
2005-01-25 6:08 ` Heiko Carstens
2005-01-25 15:20 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2005-01-25 18:10 Martin Peschke3
2005-01-25 18:40 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050124142245.GJ31455@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=greg@kroah.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.