From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 24 Jan 2005 15:37:34 +0100 From: Lars Marowsky-Bree To: Philipp Reisner , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] drbd uses wrong API for struct bio Message-ID: <20050124143733.GL5638@marowsky-bree.de> References: <20050123161633.GH24350@marowsky-bree.de> <200501241527.03616.philipp.reisner@linbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200501241527.03616.philipp.reisner@linbit.com> Cc: List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2005-01-24T15:27:03, Philipp Reisner wrote: > Hi Lars, > > Did you tested this patch ? > > If yes -> I will commit it to SVN right now... The one part is correct, but the other cases of drbd using struct bio need fixing too. If you look at the last diff (mostly converting everything to struct bio * and the API which goes with it) you'll see that mostly the container_of() macros are stumbling still, and that's fairly deep within the drbd code. Sincerely, Lars Marowsky-Brée -- High Availability & Clustering SUSE Labs, Research and Development SUSE LINUX Products GmbH - A Novell Business