All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: drbd-dev@lists.linbit.com
Cc: Lars Marowsky-Bree <lmb@suse.de>, axboe@suse.de
Subject: Re: [Drbd-dev] drbd uses wrong API for struct bio
Date: Mon, 24 Jan 2005 15:38:33 +0100	[thread overview]
Message-ID: <200501241538.33555.philipp.reisner@linbit.com> (raw)
In-Reply-To: <20050123161633.GH24350@marowsky-bree.de>

Am Sonntag, 23. Januar 2005 17:16 schrieb Lars Marowsky-Bree:
> Hi all,
>
> drbd is a quite bad offender for using bio's on stack or embedded in
> other internal structs instead of the pointer interface.
>
> The attached patch shows the 'right' way as an example, which was pretty
> easy because I could use Jens' patch for md with minimal modifications ;-)
> However, the other offending code lines are within the transfer log and
> other places, and I'm not sure Philipp wants me to mess around with that.
>
> Jens, on chip.suse.de:/local/lmb/drbd-07/drbd/ you can find the most recent
> drbd kernel code. Could you look over drbd_compat_wrappers.h line 326ff in
> particular and give me a rough rundown of what's broken? We need to fix
> this by Tuesday latest :-(
>

Hi Guys,

I just see some hectic discussion going on here, it runs as it is on 
Linux-2.6.10 as from kernel.org . Could someone tell me what the 
actual problem is ?

-Philipp
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :

  parent reply	other threads:[~2005-01-24 14:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-23 16:16 [Drbd-dev] drbd uses wrong API for struct bio Lars Marowsky-Bree
2005-01-24  8:24 ` [Drbd-dev] " Jens Axboe
2005-01-24 12:32   ` Helmut Wollmersdorfer
2005-01-24 12:35     ` Lars Marowsky-Bree
2005-01-24  9:10 ` Jens Axboe
2005-01-24  9:28   ` Lars Marowsky-Bree
2005-01-24  9:58   ` Lars Marowsky-Bree
2005-01-24 10:23     ` Jens Axboe
2005-01-24 10:28       ` Lars Marowsky-Bree
2005-01-24 12:24         ` Lars Marowsky-Bree
2005-01-24 12:52           ` Lars Marowsky-Bree
2005-01-24 14:29         ` Philipp Reisner
2005-01-26 11:15         ` Lars Ellenberg
2005-01-24 14:27     ` Philipp Reisner
2005-01-24 14:27 ` [Drbd-dev] " Philipp Reisner
2005-01-24 14:37   ` Lars Marowsky-Bree
2005-01-24 14:38 ` Philipp Reisner [this message]
2005-01-24 14:41   ` Lars Marowsky-Bree
2005-01-24 20:46     ` Lars Marowsky-Bree
2005-01-24 23:23 ` [Drbd-dev] [fix] " Lars Marowsky-Bree
2005-01-25  9:26   ` Philipp Reisner
2005-01-25  9:39     ` Jens Axboe
2005-01-25  9:58       ` Philipp Reisner
2005-01-25 10:05         ` Lars Marowsky-Bree
2005-01-25 11:44           ` Philipp Reisner
2005-01-25  9:53     ` Lars Marowsky-Bree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501241538.33555.philipp.reisner@linbit.com \
    --to=philipp.reisner@linbit.com \
    --cc=axboe@suse.de \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lmb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.