From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: keep fragment queues private to each user
Date: Tue, 25 Jan 2005 21:41:58 -0800 [thread overview]
Message-ID: <20050125214158.4be3798c.davem@davemloft.net> (raw)
In-Reply-To: <41F5D1CB.9050804@trash.net>
On Tue, 25 Jan 2005 05:57:47 +0100
Patrick McHardy <kaber@trash.net> wrote:
> This patch keeps fragment queues private to each ip_defrag user to avoid
> skbs jumping between different callers. It shouldn't change any wanted
> behaviour, the only questionable one was ip_call_ra_chain, but the RA
> option is included in each fragment. If you're fine with the patch I'm going
> to send a 2.4 version later.
Please fix the CONFIG_SMP build. You use some variable "user"
in ip_frag_intern(), yet don't add this as an argument or
anything like that.
The "user" use you added is protected by CONFIG_SMP, so my guess
is that you compile and tested this without SMP enabled.
next prev parent reply other threads:[~2005-01-26 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 4:57 [PATCH 2.6]: keep fragment queues private to each user Patrick McHardy
2005-01-25 11:57 ` Herbert Xu
2005-01-25 14:41 ` Patrick McHardy
2005-01-25 20:47 ` Herbert Xu
2005-01-26 5:41 ` David S. Miller [this message]
2005-01-26 23:30 ` Patrick McHardy
2005-01-27 2:44 ` [PATCH 2.4]: " Patrick McHardy
2005-01-27 6:29 ` [PATCH 2.6]: " David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125214158.4be3798c.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.