From: Patrick Mansfield <patmans@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: [PATCH] Change scsi send/completion logging back to terser output
Date: Tue, 25 Jan 2005 13:51:27 -0800 [thread overview]
Message-ID: <20050125215127.GA7937@us.ibm.com> (raw)
Patch against latest scsi rc fixes.
Change scsi send/completion logging back to terser output:
print_command was renamed __scsi_print_command, but two print_command
calls were renamed to scsi_print_command rather than __scsi_print_command.
__scsi_print_command at one time did not print KERN_INFO prefix, change it
back to not print it.
Signed off by: Patrick Mansfield <patmans@us.ibm.com>
diff -uprN -X /home/patman/dontdiff scsi-rc-fix-2.6.11-rc2/drivers/scsi/constants.c terser-cmd/drivers/scsi/constants.c
--- scsi-rc-fix-2.6.11-rc2/drivers/scsi/constants.c Tue Jan 25 12:26:21 2005
+++ terser-cmd/drivers/scsi/constants.c Tue Jan 25 12:27:38 2005
@@ -342,7 +342,7 @@ void __scsi_print_command(unsigned char
{
int k, len;
- print_opcode_name(command, 0, 1);
+ print_opcode_name(command, 0, 0);
if (VARIABLE_LENGTH_CMD == command[0])
len = command[7] + 8;
else
diff -uprN -X /home/patman/dontdiff scsi-rc-fix-2.6.11-rc2/drivers/scsi/scsi.c terser-cmd/drivers/scsi/scsi.c
--- scsi-rc-fix-2.6.11-rc2/drivers/scsi/scsi.c Tue Jan 25 11:08:54 2005
+++ terser-cmd/drivers/scsi/scsi.c Tue Jan 25 11:11:31 2005
@@ -424,7 +424,7 @@ void scsi_log_send(struct scsi_cmnd *cmd
* output in scsi_log_completion.
*/
printk(" ");
- scsi_print_command(cmd);
+ __scsi_print_command(cmd);
if (level > 3) {
printk(KERN_INFO "buffer = 0x%p, bufflen = %d,"
" done = 0x%p, queuecommand 0x%p\n",
@@ -492,7 +492,7 @@ void scsi_log_completion(struct scsi_cmn
printk("UNKNOWN");
}
printk(" %8x ", cmd->result);
- scsi_print_command(cmd);
+ __scsi_print_command(cmd);
if (status_byte(cmd->result) & CHECK_CONDITION) {
/*
* XXX The print_sense formatting/prefix
reply other threads:[~2005-01-25 21:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125215127.GA7937@us.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.