Re: Race in expire code

["Steinar H. Gunderson" <sgunderson@bigfoot.com>]

On Sat, Jan 29, 2005 at 09:36:31PM +0800, raven@themaw.net wrote:
> Can everyone who is maintaining downstream packages please chaeck that 
> the code in their package ends up looking like what the patch below 
> acheives.
>
> [...]
> 
>  	case EXP_STARTED:
> -		sigprocmask(SIG_SETMASK, &ready_sigs, NULL);
>  		ap.state = ST_EXPIRE;
> +		sigprocmask(SIG_SETMASK, &ready_sigs, NULL);
>  		return 0;
>  	}
>  	return 1;

The Debian packages are close, but not quite:

        case EXP_STARTED:
                sigprocmask(SIG_SETMASK, &lock_sigs, NULL);
                ap.state = ST_EXPIRE;
                sigprocmask(SIG_SETMASK, &ready_sigs, NULL);
                return 0;

I have no idea what lock_sigs does, but this should be OK, no?

/* Steinar */
-- 
Homepage: http://www.sesse.net/