Re: [PATCH] cpufreq_(ondemand|conservative)

[Alexander Clouter <alex@digriz.org.uk>]

[-- Attachment #1.1: Type: text/plain, Size: 1372 bytes --]

Dominik,

I was starting to wonder if anyone received my patches as so far _zero_
feekback :)

On Jan 29, Dominik Brodowski wrote:
> concerning patch #1:
> 
> On Sun, Jan 23, 2005 at 03:00:01PM +0000, Alexander Clouter wrote:
> > @@ -398,10 +455,10 @@
> >  		
> >  			j_dbs_info->prev_cpu_idle_up = 
> >  				kstat_cpu(j).cpustat.idle +
> > -				kstat_cpu(j).cpustat.iowait;
> > -			j_dbs_info->prev_cpu_idle_down = 
> > -				kstat_cpu(j).cpustat.idle +
> > -				kstat_cpu(j).cpustat.iowait;
> > +				kstat_cpu(j).cpustat.iowait +
> > +				kstat_cpu(j).cpustat.nice;
> 
> Why are you adding cpustat.nice here unconditionally? You don't do so in the
> sysfs write method, so I assume you should make this dependant on 
> ignore_nice here as well.
> 
Well by default 'ignore_nice = 0' so is there a need?  Look in the next hunk.

I probably have missed something, I am only a sysadmin/perl monkey with a
lpatop afterall :)

Cheers

Alex

-- 
 _________________________________________ 
/ It is wise to keep in mind that neither \
| success nor failure is ever final.      |
|                                         |
\ -- Roger Babson                         /
 ----------------------------------------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 147 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@lists.linux.org.uk
http://lists.linux.org.uk/mailman/listinfo/cpufreq