All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: rivafb: Clean up printk()'s in drivers/video/riva/fbdev.c
Date: Sun, 30 Jan 2005 11:54:57 +0000	[thread overview]
Message-ID: <20050130115457.GB3835@masina.coderock.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

On 25/01/05 19:52 -0600, James Nelson wrote:
> This patch adds KERN_ constants to all of the printk()'s that need them in
> drivers/video/riva/fbdev.c - resent after reworking the debug #defines
> 
> Signed-off-by: James Nelson <james4765@gmail.com>
> 
> diff -urN --exclude='*~' linux-2.6.11-rc2-mm1-original/drivers/video/riva/fbdev.c linux-2.6.11-rc2-mm1/drivers/video/riva/fbdev.c
> --- linux-2.6.11-rc2-mm1-original/drivers/video/riva/fbdev.c	2005-01-24 17:15:49.000000000 -0500
> +++ linux-2.6.11-rc2-mm1/drivers/video/riva/fbdev.c	2005-01-25 20:49:29.534947199 -0500
> @@ -68,18 +68,17 @@
>   *
>   * ------------------------------------------------------------------------- */
>  #ifdef CONFIG_FB_RIVA_DEBUG
> -#define NVTRACE          printk
> -#else
> -#define NVTRACE          if(0) printk
> +#define DEBUG
>  #endif

DEBUG should be defined before inclusion of kernel.h .


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2005-01-30 11:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050130115457.GB3835@masina.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.