From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: 12/34: cdrom/cdu31a: replace interruptible_sleep_on() with
Date: Sun, 30 Jan 2005 12:10:27 +0000 [thread overview]
Message-ID: <20050130121027.GC3835@masina.coderock.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On 25/01/05 15:14 -0800, Nishanth Aravamudan wrote:
> Hi,
>
> Please consider applying.
>
> Description: Use wait_event_interruptible() instead of the deprecated
> interruptible_sleep_on(). The patch is straight-forward as the macros should
> result in the same execution. Patch is compile-tested (still throws out warnings
> regarding {save,restore}_flags()).
It also indirectly calls schedule() with interrupts disabled... this
can't be right?
Domen
>
> cli();
> - while (sony_inuse) {
> - interruptible_sleep_on(&sony_wait);
> - if (signal_pending(current)) {
> - restore_flags(flags);
> - return -EAGAIN;
> - }
> + wait_event_interruptible(sony_wait, sony_inuse);
> + if (signal_pending(current)) {
> + restore_flags(flags);
> + return -EAGAIN;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-01-30 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-30 12:10 Domen Puncer [this message]
2005-01-30 19:02 ` [KJ] Re: 12/34: cdrom/cdu31a: replace interruptible_sleep_on() Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050130121027.GC3835@masina.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.