From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle DL5RB Subject: [PATCH 6/9] Use netdev_priv in baycom_ser_hdx driver Date: Sun, 30 Jan 2005 21:33:48 +0000 Message-ID: <20050130213348.GF6399@linux-mips.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline Sender: linux-hams-owner@vger.kernel.org List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hams@vger.kernel.org Cc: Jeff Garzik Eleminate the last remaining instance of a direct reference to the priv member of struct net_device. This was debug code only, so use BUG_ON() instead of printk. baycom_ser_hdx.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) Index: bk-afu/drivers/net/hamradio/baycom_ser_hdx.c =================================================================== --- bk-afu.orig/drivers/net/hamradio/baycom_ser_hdx.c +++ bk-afu/drivers/net/hamradio/baycom_ser_hdx.c @@ -570,12 +570,11 @@ struct baycom_state *bc; struct baycom_ioctl bi; - if (!dev || !dev->priv || - ((struct baycom_state *)dev->priv)->hdrv.magic != HDLCDRV_MAGIC) { - printk(KERN_ERR "bc_ioctl: invalid device struct\n"); + if (!dev) return -EINVAL; - } + bc = netdev_priv(dev); + BUG_ON(bc->hdrv.magic != HDLCDRV_MAGIC); if (cmd != SIOCDEVPRIVATE) return -ENOIOCTLCMD;