All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout()
Date: Mon, 31 Jan 2005 19:27:03 +0000	[thread overview]
Message-ID: <20050131192703.GE2683@us.ibm.com> (raw)
In-Reply-To: <20050131185159.GB21871@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Mon, Jan 31, 2005 at 10:51:59AM -0800, Greg KH wrote:
> On Fri, Jan 21, 2005 at 01:36:35PM -0800, Nishanth Aravamudan wrote:
> > Hi,
> > 
> > Please consider applying.
> > 
> > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > now unused variables. I changed the code to only add to the wait-queue if
> > necessary, but I'm not sure if this is correct.
> 
> Please at least compile your patches to make sure they build.  This one
> does not :(

I'm not seeing a build error here; what errors are coming up for you?

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-01-31 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-31 18:51 [KJ] Re: [PATCH 36/39] usb/kaweth: use wait_event_timeout() Greg KH
2005-01-31 19:27 ` Nishanth Aravamudan [this message]
2005-01-31 19:33 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050131192703.GE2683@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.