Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static

[Adrian Bunk <bunk@stusta.de>]

On Mon, Jan 31, 2005 at 10:49:05PM +0100, Stelian Pop wrote:
> On Mon, Jan 31, 2005 at 06:35:08PM +0100, Adrian Bunk wrote:
> 
> > This patch makes three needlessly global structs static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > ---
> > 
> >  drivers/char/sonypi.c |   76 +++++++++++++++++++++++++++++++++++++++++-
> >  drivers/char/sonypi.h |   74 ----------------------------------------
> >  2 files changed, 75 insertions(+), 75 deletions(-)
> 
> sonypi.h is a "local" header file used only by sonypi.c.
> 
> I would like to keep those tables in sonypi.h rather than putting 
> all into sonypi.c (or we could as well remove sonypi.h and put all the
> contents into the .c).
> 
> What about:
>...

That's also OK with me.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed