All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.10-ac11 announcement?
Date: Mon, 31 Jan 2005 18:19:37 -0500	[thread overview]
Message-ID: <20050131231935.GD24577@redhat.com> (raw)
In-Reply-To: <200502010002.50734.rjw@sisk.pl>

On Tue, Feb 01, 2005 at 12:02:49AM +0100, Rafael J. Wysocki wrote:

 > > Nothing terribly exciting here security wise but various bugs for problems
 > > people have been hitting that are now fixed upstream, and also the ULi
 > > tulip variant should now work. If you are running IPv6 you may well want
 > > the networking fixes.
 > 
 > Is there a broken-out version of the patch available?  It reboots at startup
 > (before it mounts the root fs) on my dual-Opteron box (SuSE 9.2), but -ac10
 > works fine, evidently.  I could check which changeset actually caused this to
 > happen, but I'd need to separate them.

I see this happening too. It seems to go away when I back out
this chunk..

		Dave

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.10/mm/mmap.c linux-2.6.10/mm/mmap.c
--- linux.vanilla-2.6.10/mm/mmap.c	2004-12-25 21:15:46.000000000 +0000
+++ linux-2.6.10/mm/mmap.c	2005-01-13 17:24:50.000000000 +0000
@@ -1346,7 +1346,12 @@
 	address += 4 + PAGE_SIZE - 1;
 	address &= PAGE_MASK;
 	grow = (address - vma->vm_end) >> PAGE_SHIFT;
-
+	
+	/* Someone beat us to it */
+	if (grow <= 0) {
+		anon_vma_unlock(vma);
+		return 0;
+	}
 	/* Overcommit.. */
 	if (security_vm_enough_memory(grow)) {
 		anon_vma_unlock(vma);
@@ -1409,6 +1421,11 @@
 	address &= PAGE_MASK;
 	grow = (vma->vm_start - address) >> PAGE_SHIFT;
 
+	/* Someone beat us to it */
+	if (grow <= 0) {
+		anon_vma_unlock(vma);
+		return 0;
+	}
 	/* Overcommit.. */
 	if (security_vm_enough_memory(grow)) {
 		anon_vma_unlock(vma);


  reply	other threads:[~2005-01-31 23:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-29 19:12 2.6.10-ac11 announcement? Ralf Hildebrandt
2005-01-31  8:05 ` Alan Cox
2005-01-31 23:02   ` Rafael J. Wysocki
2005-01-31 23:19     ` Dave Jones [this message]
2005-01-31 23:09       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050131231935.GD24577@redhat.com \
    --to=davej@redhat.com \
    --cc=Ralf.Hildebrandt@charite.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.