From: Greg KH <greg@kroah.com>
To: Ed L Cashin <ecashin@coraid.com>
Cc: linux-kernel@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [2.6 patch] drivers/block/aoe/aoechr.c cleanups
Date: Mon, 31 Jan 2005 23:54:13 -0800 [thread overview]
Message-ID: <20050201075413.GF21608@kroah.com> (raw)
In-Reply-To: <87acqpu0od.fsf@coraid.com>
On Mon, Jan 31, 2005 at 09:34:58AM -0500, Ed L Cashin wrote:
> Adrian Bunk <bunk@stusta.de> writes:
>
> > This patch contains the following cleanups:
> > - make the needlessly global struct aoe_fops static
> > - #if 0 the unused global function aoechr_hdump
>
> Thanks for the patch. The original patch leaves the prototype for
> aoechr_hdump in aoe.h, but since this function is just for debugging,
> it seems better to just take both prototype and definition out.
>
>
> remove aoechr_hdump
> make aoe_fops static
>
> Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Applied, thanks.
greg k-h
prev parent reply other threads:[~2005-02-01 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 13:35 [2.6 patch] drivers/block/aoe/aoechr.c cleanups Adrian Bunk
2005-01-31 14:34 ` Ed L Cashin
2005-02-01 7:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050201075413.GF21608@kroah.com \
--to=greg@kroah.com \
--cc=bunk@stusta.de \
--cc=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.