From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] usb/mdc800: replace wake_up() with
Date: Tue, 01 Feb 2005 21:07:17 +0000 [thread overview]
Message-ID: <20050201210717.GD2575@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1766 bytes --]
On Tue, Feb 01, 2005 at 11:51:36AM -0800, Nishanth Aravamudan wrote:
> On Mon, Jan 31, 2005 at 10:58:02AM -0800, Greg KH wrote:
> > On Fri, Jan 21, 2005 at 01:37:39PM -0800, Nishanth Aravamudan wrote:
> > > Hi,
> > >
> > > Please consider applying.
> > >
> > > Description: Use wait_event_timeout() instead of custom wait-queue code. Remove
> > > now unused variables.
> > >
> > > Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> >
> > Applied, thanks.
>
> Greg,
>
> This should fix the behavior of the previous patch (probably not noticed yet).
> The wake_up*() was not matched properly in the first patch (fixed below). Please
> consider reverting the previous patch and applying this one instead. I think it
> may actually have been somewhat broken in the original code, actually :)
Description: Modify the wake_up*() calls to match the wait_event*() ones
from a previous patch.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.11-rc2-kj-v/drivers/usb/image/mdc800.c 2005-02-01 12:58:22.000000000 -0800
+++ 2.6.11-rc2-kj/drivers/usb/image/mdc800.c 2005-02-01 13:00:52.000000000 -0800
@@ -331,7 +331,7 @@ static void mdc800_usb_irq (struct urb *
{
mdc800->camera_request_ready=0;
mdc800->irq_woken=1;
- wake_up_interruptible (&mdc800->irq_wait);
+ wake_up (&mdc800->irq_wait);
}
}
@@ -386,7 +386,7 @@ static void mdc800_usb_write_notify (str
mdc800->state=READY;
}
mdc800->written = 1;
- wake_up_interruptible (&mdc800->write_wait);
+ wake_up (&mdc800->write_wait);
}
@@ -414,7 +414,7 @@ static void mdc800_usb_download_notify (
err ("request bytes fails (status:%i)", urb->status);
}
mdc800->downloaded = 1;
- wake_up_interruptible (&mdc800->download_wait);
+ wake_up (&mdc800->download_wait);
}
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-02-01 21:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050201210717.GD2575@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.