From: "David S. Miller" <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] A BTFIXUP'd fix for pte_read()
Date: Thu, 03 Feb 2005 06:27:41 +0000 [thread overview]
Message-ID: <20050202222741.5284085f.davem@davemloft.net> (raw)
In-Reply-To: <20050202200409.GA30839@artsapartment.org>
On Wed, 02 Feb 2005 22:22:24 -0600
"Tom 'spot' Callaway" <tcallawa@redhat.com> wrote:
> On Wed, 2005-02-02 at 15:32 -0800, David S. Miller wrote:
>
> > I disagree with Tom's patch in that it puts this huge switch()
> > statement inline. The whole point of BTFIXUP_HIGH() is that it
> > resolves the call to a single instruction which can be easily
> > patched at runtime.
> >
> > If it's going to expand to multiple BTFIXUP_HIGH() calls and a
> > switch statement, just make it a normal BTFIXUP() to a function
> > and place the implementation in sun4c.c and sun4m.c
>
> How about this instead?
Perfect Tom.
next prev parent reply other threads:[~2005-02-03 6:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-02 20:04 [PATCH] A BTFIXUP'd fix for pte_read() Art Haas
2005-02-02 21:54 ` Tom 'spot' Callaway
2005-02-02 22:40 ` William Lee Irwin III
2005-02-02 23:32 ` David S. Miller
2005-02-03 0:52 ` David S. Miller
2005-02-03 0:55 ` William Lee Irwin III
2005-02-03 4:22 ` Tom 'spot' Callaway
2005-02-03 6:27 ` David S. Miller [this message]
2005-02-03 9:13 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050202222741.5284085f.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.