Re: Corrections to mlmmj-1.2.2

[Mads Martin Joergensen <mmj@mmj.dk>]

* Uffe Jakobsen <uffe@uffe.org> [Feb 03. 2005 15:30]:
> 
> Hi,
> 
> Using Fedore Core 2 and the new mlmmj-1.2.2 I've tried to follow your 
> README in order to establish the mlmmj-test list (for evaluation pusposes)
> 
> I've found the following corrections to your README document and sources:
> 
> "/etc/aliases": in order to support arguments to the proc alias the command 
> needs to be enclosed in quotes like this:
> 
> mlmmj-test:     |"/usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test/"

I think I had it like that once, but someone claimed it should be
otherwise. Is this mailserver dependant?

> Somewhere along the road /usr/local/bin/mlmmj-recieve or some other binary 
> called by mlmmj-recieve logs this message:
> log_oper.c:71: Could not open 
> /var/spool/mlmmj/mlmmj-testmlmmj.operation.log: Permission denied
> 
> I found out that the problem var related to a missing (final) '/' in the 
> arguments to mlmmj-recieve.
> 
> This will provoke the error: /usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test
> 
> Introducing a last '/' will fix the error: /usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test/
> 
> I guess that you've forgot to postpend a '/' between the listdir and the 
> file name for the logfile.

Good spotting! Here's a patch to fix it:

--- src/log_oper.c
+++ src/log_oper.c
@@ -49,7 +49,7 @@
        va_list ap;
        size_t i;
 
-       logfilename = concatstr(2, prefix, basename);
+       logfilename = concatstr(3, prefix, "/", basename);
        statres = lstat(logfilename, &st);
        if(statres < 0 && errno != ENOENT) {
                log_error(LOG_ARGS, "Could not stat logfile %s", logfilename);


> Suggestion the README document does not mention anything about how to build 
> the mlmmj-project.
> Maybe it was an idea just to mention that in order to build/install mlmmj 
> the user have to run "./configure" followed by "make" and "make install"... 
> ?

Yeah, you're right. Will do.

> Anyway mlmmj have passed the first hours of my evaluation - it looks as a 
> very promising alternativ to ezmlm/ezmlm-idx !!! :-)

Glad you like it!

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.