All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: john stultz <johnstul@us.ibm.com>, Andi Kleen <ak@suse.de>,
	lkml <linux-kernel@vger.kernel.org>,
	keith maanthey <kmannth@us.ibm.com>,
	Max Asbock <masbock@us.ibm.com>, Chris McDermott <lcm@us.ibm.com>,
	andrew@walrond.org
Subject: Re: i386 HPET code
Date: Thu, 3 Feb 2005 22:22:12 +0100	[thread overview]
Message-ID: <20050203212212.GD3181@wotan.suse.de> (raw)
In-Reply-To: <20050203120233.A23267@unix-os.sc.intel.com>

> Basically I am thinking of something like this will be a good generic solution
> in place of simple two writes.
> 
> for (i = 0 ; i <some number for max retries>; i++) {
> 	hpet_writel(hpet_tick, HPET_T0_CMP);
> 	if (hpet_tick == hpet_readl(hpet_tick, HPET_T0_CMP))
> 		break;
> }

Makes sense. There were so many bugs in PIT timer access over time,
it would be probably a miracle if the hardware engineers got all
the HPET implementations right ;-) 

If you do a fix like this please change x86-64 too.

-Andi


  reply	other threads:[~2005-02-03 21:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-03 14:28 i386 HPET code Pallipadi, Venkatesh
2005-02-03 19:30 ` john stultz
2005-02-03 20:02   ` Venkatesh Pallipadi
2005-02-03 21:22     ` Andi Kleen [this message]
2005-02-04 17:22     ` Andrew Walrond
2005-02-03 21:30 ` Andi Kleen
2005-02-04 19:28   ` Vojtech Pavlik
2005-02-04 20:02   ` Vojtech Pavlik
2005-02-04 20:03     ` Vojtech Pavlik
2005-02-04 23:41     ` [PATCH][i386] HPET setup, duplicate HPET_T0_CMP needed for some platforms Venkatesh Pallipadi
2005-02-05 10:55       ` Andrew Walrond
2005-02-06 15:58       ` Giuseppe Bilotta
  -- strict thread matches above, loose matches on Subject: below --
2005-02-03  2:05 i386 HPET code john stultz
2005-02-03  8:37 ` Andrew Walrond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050203212212.GD3181@wotan.suse.de \
    --to=ak@suse.de \
    --cc=andrew@walrond.org \
    --cc=johnstul@us.ibm.com \
    --cc=kmannth@us.ibm.com \
    --cc=lcm@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masbock@us.ibm.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.