From: "David S. Miller" <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: fix cg14 with serial console
Date: Sat, 05 Feb 2005 05:41:42 +0000 [thread overview]
Message-ID: <20050204214142.0822dbda.davem@davemloft.net> (raw)
In-Reply-To: <41FF079C.7070007@mc.net>
On Fri, 04 Feb 2005 22:04:38 -0600
Bob Breuer <breuerr@mc.net> wrote:
> I suppose the idea of creating stubs for the missing prom
> functions on sparc64 has already been considered and rejected.
Actually, this sounds like a nice cleanup idea. It just hasn't
been done.
> Anyway, for this bug with the cg14, the return value of
> prom_getproperty() was not checked. A quick check of 2.6.10 shows
> that the return value of prom_getproperty() is not used in 25 out
> of 111 cases for sparc32. Would it make sense to mark this
> function with __must_check? I suppose the cleanups would be too
> much effort for too little gain.
That would be a great idea. In particular, things like
tree.c:prom_nodematch() should check (and return "0" when
error occurs).
> And for good measure, I have appended a revised patch.
Thanks Bob, I'll integrate.
next prev parent reply other threads:[~2005-02-05 5:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 4:37 fix cg14 with serial console Bob Breuer
2005-02-01 4:44 ` David S. Miller
2005-02-05 4:04 ` Bob Breuer
2005-02-05 5:41 ` David S. Miller [this message]
2005-02-06 22:23 ` Art Haas
2005-02-15 18:06 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050204214142.0822dbda.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.