Re: [PATCH] TCP window tracking over-window handling

[Phil Oester <kernel@linuxace.com>]

On Mon, Feb 07, 2005 at 11:32:27AM +0100, Jozsef Kadlecsik wrote:
> Actually the real governing rule is that packets must intersect the
> window: there may be segments before the left or after the right edge.
> Moreover, the receivers may keep the segments over the window for later
> processing, and your recording just proves it does happen.
> 
> So we can either follow the article and drop the assumption about
> receivers trimming the segments over the window or adjust the code to
> meet RFC793 and real life traffic patterns. I believe the second
> approach would be preferable because then conntrack wouldn't drop
> legitimate packets and there were less false alarms.
> 
> The first attached patch (your version with some modifications to
> complete it) implements the first variation.
> 
> The second one aims to implement the more RFC-compatible window tracking
> code. It is slightly tested using the first window tracking tests by
> nfsim. I'm working on writing more tests to cover as many cases as
> possible.

Both look good, but would it be best to merge the less intrusive alternative
#1 for 2.6.11, then update to alternative #2 early in 2.6.12 so it can receive
more testing?

Phil