From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Andi Kleen <ak@suse.de>,
rmk@arm.linux.org.uk, torvalds@osdl.org, akpm@osdl.org,
dwmw2@infradead.org, linux-arch@vger.kernel.org
Subject: Re: [patch 19/24] TASK_SIZE is variable.
Date: Mon, 7 Feb 2005 21:15:47 +0100 [thread overview]
Message-ID: <20050207201547.GA6790@wotan.suse.de> (raw)
In-Reply-To: <20050207112837.5594c314.davem@davemloft.net>
On Mon, Feb 07, 2005 at 11:28:37AM -0800, David S. Miller wrote:
> On Mon, 7 Feb 2005 09:11:06 +0100
> Andi Kleen <ak@suse.de> wrote:
>
> > Also BTW your proposed check wouldn't catch all cases anyways,
> > it would only handle the case where the access_ok() check is
> > done inside the KERNEL_DS.
>
> There must be a verify area done (either via explicit call or
> via the user access macros which do not have the "__" prefix)
> for each range of "userspace" accesses done through the uaccess.h accessors.
Yes, but it is done outside KERNEL_DS (otherwise it is a security hole)
And then later in KERNEL_DS there is no verify_area.
So this change wouldn't help you at all because it would rarely if
ever catch any bugs.
-Andi
next prev parent reply other threads:[~2005-02-07 20:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200502050150.j151osl11380@mail.osdl.org>
2005-02-05 2:16 ` [patch 19/24] TASK_SIZE is variable Linus Torvalds
2005-02-05 3:29 ` Linus Torvalds
2005-02-05 5:52 ` David S. Miller
2005-02-07 10:59 ` David Howells
2005-02-07 19:30 ` David S. Miller
2005-02-08 9:05 ` Martin Schwidefsky
2005-02-08 19:09 ` David S. Miller
2005-02-05 9:06 ` Russell King
2005-02-05 23:44 ` David S. Miller
2005-02-06 10:50 ` Andi Kleen
2005-02-06 21:19 ` David S. Miller
2005-02-06 21:31 ` Andi Kleen
2005-02-06 21:31 ` David S. Miller
2005-02-06 21:50 ` Andi Kleen
2005-02-06 22:25 ` David S. Miller
2005-02-06 22:31 ` David S. Miller
2005-02-07 8:11 ` Andi Kleen
2005-02-07 19:28 ` David S. Miller
2005-02-07 20:15 ` Andi Kleen [this message]
2005-02-07 20:13 ` David S. Miller
2005-02-05 6:54 ` Andi Kleen
2005-02-05 7:18 ` Andrew Morton
2005-02-05 7:40 ` Andi Kleen
2005-02-05 23:27 ` David S. Miller
2005-02-06 10:38 ` Andi Kleen
2005-02-06 13:05 ` Matthew Wilcox
2005-02-05 23:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050207201547.GA6790@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.