From: Dave Jones <davej@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] updated kj-devel.pl
Date: Tue, 08 Feb 2005 01:02:34 +0000 [thread overview]
Message-ID: <20050208010233.GB6853@redhat.com> (raw)
In-Reply-To: <200502041215.01436.vicente.feito@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Mon, Feb 07, 2005 at 04:46:58PM -0800, Randy.Dunlap wrote:
> spinlock misuse detection is often not straightforward.
> E.g., in kernel/acct.c (2.6.11-rc3), I'm getting:
> Lock closed on line 115
> Lock closed on line 162
> Obtained spinlock on line 198, but never unlocked.
> acct.c:198: spin_lock(&acct_globals.lock);
>
>
> Lock closed on line 247
> Lock closed on line 263
> Lock closed on line 521
> ^^^^^^^^^^^^^^ these line numbers appear to be off by 1 line.
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
You're probably best off throwing away the spinlock detection code.
Its horrible, and breaks really easily. I'm almost
embarressed to admit to writing it.
Sparse should be able to do a much better job.
Dave
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-02-08 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 12:15 [KJ] updated kj-devel.pl Vicente Feito
2005-02-08 0:46 ` Randy.Dunlap
2005-02-08 1:02 ` Dave Jones [this message]
2005-02-08 8:10 ` Vicente Feito
2005-02-08 8:18 ` Vicente Feito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050208010233.GB6853@redhat.com \
--to=davej@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.