All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Joseph Pingenot <trelane@digitasaru.net>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Osterlund <petero2@telia.com>,
	Vojtech Pavlik <vojtech@suse.cz>
Subject: [PATCH] Fix ALPS sync loss
Date: Tue, 8 Feb 2005 18:40:12 -0500	[thread overview]
Message-ID: <200502081840.12520.dtor_core@ameritech.net> (raw)

Hi,

Here is the promised patch. It turns out protocol validation code was
a bit (or rather a byte ;) ) off.

Please let me know if it fixes your touchpad and I believe it would be
nice to have it in 2.6.11.

-- 
Dmitry


===================================================================


ChangeSet@1.2147, 2005-02-08 18:12:06-05:00, dtor_core@ameritech.net
  Input: alps - fix protocol validation rules causing touchpad
         to lose sync if an absolute packet is received after
         a relative packet with negative Y displacement.
  
  Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  


 alps.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


===================================================================



diff -Nru a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
--- a/drivers/input/mouse/alps.c	2005-02-08 18:16:27 -05:00
+++ b/drivers/input/mouse/alps.c	2005-02-08 18:16:27 -05:00
@@ -198,8 +198,8 @@
 		return PSMOUSE_BAD_DATA;
 
 	/* Bytes 2 - 6 should have 0 in the highest bit */
-	if (psmouse->pktcnt > 1 && psmouse->pktcnt <= 6 &&
-	    (psmouse->packet[psmouse->pktcnt] & 0x80))
+	if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 &&
+	    (psmouse->packet[psmouse->pktcnt - 1] & 0x80))
 		return PSMOUSE_BAD_DATA;
 
 	if (psmouse->pktcnt == 6) {

             reply	other threads:[~2005-02-08 23:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-08 23:40 Dmitry Torokhov [this message]
2005-02-09  7:23 ` [PATCH] Fix ALPS sync loss Vojtech Pavlik
2005-02-09 17:35 ` Joseph Pingenot
2005-02-10 19:54   ` Dmitry Torokhov
     [not found] <mailman.1107906420.26313.linux-kernel2news@redhat.com>
2005-02-10 19:07 ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200502081840.12520.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    --cc=trelane@digitasaru.net \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.