From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: still BUG's for smp_processor_id() on interrupt
Date: Tue, 8 Feb 2005 22:44:35 -0800 [thread overview]
Message-ID: <20050209064435.GA4897@plap.qlogic.org> (raw)
In-Reply-To: <20050209010929.GA2933@us.ibm.com>
On Tue, 08 Feb 2005, Patrick Mansfield wrote:
> I'm still getting lots of BUG's for the smp_processor_id, but via the
> interrupt function.
>
It's during the driver's init-time polling for interrupts...
> I am running the latest bk, it has your patch to qla_os.c:
>
> [elm3b79 qla2xxx]$ grep smp_proc qla_os.c
> if (_smp_processor_id() == ha->last_irq_cpu || was_empty)
>
> I'm running on a NUMAQ (sometimes has funky latencies). There are no
> errors for simple IO (dd if=/dev/sda of=/dev/null bs=64k). There are about
> 40 disk drives attached.
>
Argg -- that was careless... Again, the smp_processor_id() is used
only as a heuristic. The attached patch should quash the noise.
Thanks.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
===== drivers/scsi/qla2xxx/qla_isr.c 1.23 vs edited =====
--- 1.23/drivers/scsi/qla2xxx/qla_isr.c 2005-02-04 10:24:27 -08:00
+++ edited/drivers/scsi/qla2xxx/qla_isr.c 2005-02-08 22:41:08 -08:00
@@ -91,7 +91,7 @@
}
spin_unlock_irqrestore(&ha->hardware_lock, flags);
- ha->last_irq_cpu = smp_processor_id();
+ ha->last_irq_cpu = _smp_processor_id();
ha->total_isr_cnt++;
if (test_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags) &&
@@ -200,7 +200,7 @@
}
spin_unlock_irqrestore(&ha->hardware_lock, flags);
- ha->last_irq_cpu = smp_processor_id();
+ ha->last_irq_cpu = _smp_processor_id();
ha->total_isr_cnt++;
if (test_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags) &&
next prev parent reply other threads:[~2005-02-09 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 1:09 still BUG's for smp_processor_id() on interrupt Patrick Mansfield
2005-02-09 6:44 ` Andrew Vasquez [this message]
2005-02-09 17:22 ` Patrick Mansfield
-- strict thread matches above, loose matches on Subject: below --
2005-02-09 18:13 James.Smart
2005-02-09 18:26 ` Patrick Mansfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050209064435.GA4897@plap.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.