From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Lee Irwin III Date: Thu, 10 Feb 2005 09:41:10 +0000 Subject: Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32 Message-Id: <20050210094110.GD13009@holomorphy.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sparclinux@vger.kernel.org On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos wrote: >> smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon >> and cause compilation errors in single statement context, like >> if-then-else on line 358 in include/linux/skbuff.h. This patch removes >> all three offending semicolons to make it compile. >> Signed-off-by: Meelis Roos On Thu, Feb 10, 2005 at 12:23:41AM -0800, David S. Miller wrote: > Sorry, I should have checked this out when I fixed the same exact > bug on sparc64. > I'll apply and push upstream, thanks. Sorry I didn't get around to this. Thanks for taking care of it. -- wli