From: William Lee Irwin III <wli@holomorphy.com>
To: sparclinux@vger.kernel.org
Subject: Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32
Date: Thu, 10 Feb 2005 19:42:16 +0000 [thread overview]
Message-ID: <20050210194216.GH13009@holomorphy.com> (raw)
In-Reply-To: <Pine.SOC.4.61.0502092331420.4099@math.ut.ee>
On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos <mroos@linux.ee> wrote:
>>> smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon
>>> and cause compilation errors in single statement context, like
>>> if-then-else on line 358 in include/linux/skbuff.h. This patch removes
>>> all three offending semicolons to make it compile.
>>> Signed-off-by: Meelis Roos <mroos@linux.ee>
On Thu, Feb 10, 2005 at 12:23:41AM -0800, David S. Miller wrote:
>> Sorry, I should have checked this out when I fixed the same exact
> bug on sparc64.
>> I'll apply and push upstream, thanks.
On Thu, Feb 10, 2005 at 01:41:10AM -0800, William Lee Irwin III wrote:
> Sorry I didn't get around to this. Thanks for taking care of it.
I regenerated the diff by hand because it didn't apply to bk for some
reason, maybe mangled whitespace.
Acked-by: William Irwin <wli@holomorphy.com>
-- wli
smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon
and cause compilation errors in single statement context, like
if-then-else on line 358 in include/linux/skbuff.h. This patch removes
all three offending semicolons to make it compile.
Signed-off-by: Meelis Roos <mroos@linux.ee>
=== include/asm-sparc/system.h 1.21 vs edited ==--- 1.21/include/asm-sparc/system.h Mon Jul 5 03:33:38 2004
+++ edited/include/asm-sparc/system.h Thu Feb 10 11:39:07 2005
@@ -195,9 +195,9 @@
#define read_barrier_depends() do { } while(0)
#define set_mb(__var, __value) do { __var = __value; mb(); } while(0)
#define set_wmb(__var, __value) set_mb(__var, __value)
-#define smp_mb() __asm__ __volatile__("":::"memory");
-#define smp_rmb() __asm__ __volatile__("":::"memory");
-#define smp_wmb() __asm__ __volatile__("":::"memory");
+#define smp_mb() __asm__ __volatile__("":::"memory")
+#define smp_rmb() __asm__ __volatile__("":::"memory")
+#define smp_wmb() __asm__ __volatile__("":::"memory")
#define smp_read_barrier_depends() do { } while(0)
#define nop() __asm__ __volatile__ ("nop");
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2005-02-10 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 7:19 [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32 Meelis Roos
2005-02-10 8:23 ` David S. Miller
2005-02-10 9:41 ` William Lee Irwin III
2005-02-10 19:42 ` William Lee Irwin III [this message]
2005-02-11 3:05 ` Bob Breuer
2005-02-11 3:31 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210194216.GH13009@holomorphy.com \
--to=wli@holomorphy.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.