From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup
Date: Thu, 10 Feb 2005 22:15:30 +0000 [thread overview]
Message-ID: <20050210221530.GA13548@kroah.com> (raw)
In-Reply-To: <420BEF84.30631.5873DC@localhost>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Thu, Feb 10, 2005 at 11:34:28PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: add MODULE definition compile fence so MODULE_DEVICE_TABLE
> vars not declared when compiled into the kernel
>
> Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
>
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h
> --- linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h 2005-02-03 03:56:10.000000000 +0200
> +++ linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h 2005-02-07 21:19:25.000000000 +0200
> @@ -139,6 +139,7 @@ static struct usb_midi_device usb_midi_d
>
> #define VENDOR_SPECIFIC_USB_MIDI_DEVICES (sizeof(usb_midi_devices)/sizeof(struct usb_midi_device))
>
> +#ifdef MODULE
> /* for Hot-Plugging */
>
> static struct usb_device_id usb_midi_ids [] = {
> @@ -157,6 +158,7 @@ static struct usb_device_id usb_midi_ids
> };
>
> MODULE_DEVICE_TABLE (usb, usb_midi_ids);
> +#endif /* MODULE */
No, these types of "fixes" have been rejected many times in the past,
and will be rejected again... It's just not worth it.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-02-10 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 21:34 [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup Stephen Biggs
2005-02-10 22:15 ` Greg KH [this message]
2005-02-11 0:32 ` Stephen Biggs
2005-02-11 0:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050210221530.GA13548@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.