From: Alexey Dobriyan <adobriyan@mail.ru>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH][18/26] drivers/usb/image/* - compile warning cleanup
Date: Thu, 10 Feb 2005 22:36:10 +0000 [thread overview]
Message-ID: <200502110127.55762.adobriyan@mail.ru> (raw)
In-Reply-To: <420BEF84.5020.58734F@localhost>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Thursday 10 February 2005 23:34, Stephen Biggs wrote:
> --- linux-2.6.11-rc3-mm-original/drivers/usb/image/microtek.c
> +++ linux-2.6.11-rc3-mm/drivers/usb/image/microtek.c
> @@ -809,7 +809,11 @@ static int mts_usb_probe(struct usb_inte
> goto out_free_urb;
>
> new_desc->host->hostdata[0] = (unsigned long)new_desc;
> - scsi_add_host(new_desc->host, NULL); /* XXX handle failure */
> + if(scsi_add_host(new_desc->host, NULL)) {
> + usb_free_urb(new_desc->urb);
> + kfree(new_desc);
> + return -EIO;
> + }
Should be:
if (scsi_add_host(new_desc->host, NULL)) {
rc = -E____;
goto out_free_urb;
}
Yes, yes, I know. There is no rc in mts_usb_probe. ;-)
Alexey
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-02-10 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-10 21:34 [KJ] [PATCH][18/26] drivers/usb/image/* - compile warning cleanup Stephen Biggs
2005-02-10 22:36 ` Alexey Dobriyan [this message]
2005-02-10 23:15 ` Stephen Biggs
2005-02-10 23:23 ` Stephen Biggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502110127.55762.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.