From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1CzfRu-0006kY-Vk for mharc-grub-devel@gnu.org; Fri, 11 Feb 2005 13:23:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CzfRj-0006ed-S0 for grub-devel@gnu.org; Fri, 11 Feb 2005 13:23:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CzfRX-0006Z3-VQ for grub-devel@gnu.org; Fri, 11 Feb 2005 13:23:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CzfRX-0006Xv-AI for grub-devel@gnu.org; Fri, 11 Feb 2005 13:23:03 -0500 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CzfB7-00048Z-NO for grub-devel@gnu.org; Fri, 11 Feb 2005 13:06:05 -0500 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 49464FA9FBC1 for ; Fri, 11 Feb 2005 19:06:04 +0100 (CET) Received: from 127.0.0.1 ([127.0.0.1] helo=localhost) by ASSP-nospam ; 11 Feb 05 18:06:04 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 11 Feb 2005 19:07:06 +0100 User-Agent: KMail/1.7.1 References: <20050201044708.GB3969@zulo.hadrons.org> <200502102021.33225.okuji@enbug.org> <87fz03qa9t.fsf@marco.marco-g.com> In-Reply-To: <87fz03qa9t.fsf@marco.marco-g.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200502111907.06371.okuji@enbug.org> Subject: Re: consolidate ELF header checks X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2005 18:23:23 -0000 On Friday 11 February 2005 18:25, Marco Gerards wrote: > I assume that means I can commit the patch. I'll do that on Sunday > evening. Just tell me if there are still problems and I will wait > with committing the patch. One minor problem in his patch is this part: @@ -497,12 +520,25 @@ grub_dl_load_core (void *addr, grub_size =A0 =A0grub_dl_t mod; =A0 =A0 =A0 =A0e =3D addr; =2D =A0if (! grub_arch_dl_check_header (e, size)) + =A0if (grub_dl_check_header (e, size)) =A0 =A0 =A0{ =A0 =A0 =A0 =A0grub_error (GRUB_ERR_BAD_MODULE, "invalid ELF header"); =A0 =A0 =A0 =A0return 0; =A0 =A0 =A0} =A0 =A0 As grub_dl_check_header is supposed to provide a more detailed error,=20 grub_dl_load_core should not set a new error here. Once this is fixed, I have no objection. Okuji