From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] connlimit match fixes for >= 2.6.10
Date: Sat, 12 Feb 2005 13:32:54 -0800 [thread overview]
Message-ID: <20050212213254.GA11884@linuxace.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Below updates connlimit for:
1) removal of nf_ct_info
2) removal of ctrack
Fixes bugzilla #'s 268 and 286.
Phil
[-- Attachment #2: patch-connlimit --]
[-- Type: text/plain, Size: 2310 bytes --]
diff -ru pom-orig/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c pom-new/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c
--- pom-orig/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c 2004-02-19 18:30:21.000000000 -0500
+++ pom-new/connlimit/linux-2.6/net/ipv4/netfilter/ipt_connlimit.c 2005-02-12 16:05:34.896897472 -0500
@@ -58,6 +58,7 @@
int addit = 1, matches = 0;
struct ip_conntrack_tuple tuple;
struct ip_conntrack_tuple_hash *found;
+ struct ip_conntrack *foundct = NULL;
struct ipt_connlimit_conn *conn;
struct list_head *hash,*lh;
@@ -69,9 +70,11 @@
for (lh = hash->next; lh != hash; lh = lh->next) {
conn = list_entry(lh,struct ipt_connlimit_conn,list);
found = ip_conntrack_find_get(&conn->tuple,ct);
+ if (found)
+ foundct = tuplehash_to_ctrack(found);
if (0 == memcmp(&conn->tuple,&tuple,sizeof(tuple)) &&
found != NULL &&
- found->ctrack->proto.tcp.state != TCP_CONNTRACK_TIME_WAIT) {
+ foundct->proto.tcp.state != TCP_CONNTRACK_TIME_WAIT) {
/* Just to be sure we have it only once in the list.
We should'nt see tuples twice unless someone hooks this
into a table without "-p tcp --syn" */
@@ -82,7 +85,7 @@
ipt_iphash(addr & mask),
NIPQUAD(conn->tuple.src.ip), ntohs(conn->tuple.src.u.tcp.port),
NIPQUAD(conn->tuple.dst.ip), ntohs(conn->tuple.dst.u.tcp.port),
- (NULL != found) ? tcp[found->ctrack->proto.tcp.state] : "gone");
+ (NULL != found) ? tcp[foundct->proto.tcp.state] : "gone");
#endif
if (NULL == found) {
/* this one is gone */
@@ -91,20 +94,20 @@
kfree(conn);
continue;
}
- if (found->ctrack->proto.tcp.state == TCP_CONNTRACK_TIME_WAIT) {
+ if (foundct->proto.tcp.state == TCP_CONNTRACK_TIME_WAIT) {
/* we don't care about connections which are
closed already -> ditch it */
lh = lh->prev;
list_del(lh->next);
kfree(conn);
- nf_conntrack_put(&found->ctrack->infos[0]);
+ nf_conntrack_put(&foundct->ct_general);
continue;
}
if ((addr & mask) == (conn->tuple.src.ip & mask)) {
/* same source IP address -> be counted! */
matches++;
}
- nf_conntrack_put(&found->ctrack->infos[0]);
+ nf_conntrack_put(&foundct->ct_general);
}
if (addit) {
/* save the new connection in our list */
next reply other threads:[~2005-02-12 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-12 21:32 Phil Oester [this message]
2005-02-14 23:05 ` [PATCH] connlimit match fixes for >= 2.6.10 Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050212213254.GA11884@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.