Re: [linux-2.6.10] radeonfb / oops

["Paweł Sikora" <pluto@pld-linux.org>]

On Saturday 12 of February 2005 21:59, Paweł Sikora wrote:
> On Saturday 12 of February 2005 18:34, Kronos wrote:
> > It looks like this (in fbsplash_init):
> >
> >                 vc->vc_splash.theme = kmalloc((strlen(fbsplash_theme)+1)
> > * sizeof(char), GFP_KERNEL); strcpy(vc->vc_splash.theme, fbsplash_theme);
> >
> > IMHO kmalloc failed and strcpy used the NULL pointer. Try to change the
> > code in this way:
> >
> > vc->vc_splash.theme = kmalloc((strlen(fbsplash_theme)+1), GFP_KERNEL);
> > if (!vc->vc_splash.theme) {
> >         misc_deregister(&splash_dev);
> >         printk(KERN_ERR "fbsplash_init: ZOMG!!! Out of mem!\n");
> >         return -ENOMEM;
> > }
> > strcpy(vc->vc_splash.theme, fbsplash_theme);
>
> You're right.
>
> (...)
> pldworkstation Console: switching to colour frame buffer device 80x30
> pldworkstation fbsplash_init: ZOMG!!! Out of mem!
> (...)
>
> btw).
>
> Bellows fix (from Spock) should help for kmalloc.
> I'll test it tomorrow...
>
> --- a/drivers/video/fbsplash.c.orig  2005-02-12 21:14:47.000000000 +0100
> +++ b/drivers/video/fbsplash.c       2005-02-12 21:15:34.272313976 +0100
> @@ -59,7 +59,7 @@
>
> int fbsplash_mode = 0;
> char fbsplash_path[KMOD_PATH_LEN] = "/sbin/splash_helper";
> -static char fbsplash_theme[FB_SPLASH_THEME_LEN] __initdata = "default";
> +static char fbsplash_theme[FB_SPLASH_THEME_LEN] = "default";
>
> int fbsplash_call_helper(char* cmd, unsigned short vc)
> {

It helped. Case closed :-)

-- 
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click