From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 16/18] sound/oss/ remove pci_find_{device, subsys}
Date: Mon, 14 Feb 2005 18:41:19 +0000 [thread overview]
Message-ID: <20050214184119.GG7815@kroah.com> (raw)
In-Reply-To: <200502141158.09192.amitg@calsoftinc.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Mon, Feb 14, 2005 at 11:58:07AM +0530, Amit Gud wrote:
> Remove deprecated pci_find_device and pci_find_subsys
>
> Do consider applying.
>
> Signed-off-by: Amit Gud <gud@eth.net>
>
> diff -uprN orig/sound/oss/cs46xx.c linux-2.6.11-rc3/sound/oss/cs46xx.c
> --- orig/sound/oss/cs46xx.c 2005-02-11 15:20:12.000000000 +0530
> +++ linux-2.6.11-rc3/sound/oss/cs46xx.c 2005-02-14 05:33:56.000000000 +0530
> @@ -3131,7 +3131,7 @@ static void clkrun_hack(struct cs_card *
>
> card->active+=change;
>
> - acpi_dev = pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_3, NULL);
> + acpi_dev = pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371AB_3, NULL);
> if(acpi_dev == NULL)
> return; /* Not a thinkpad thats for sure */
>
No, incorrect replacement. Jeff, please do not apply.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-02-14 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 6:40 [KJ] [PATCH 16/18] sound/oss/ remove pci_find_{device, subsys} Amit Gud
2005-02-14 18:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050214184119.GG7815@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.