All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: framebuffer blanking
Date: Tue, 15 Feb 2005 16:10:32 +0000	[thread overview]
Message-ID: <20050215081032.40d34b45.davem@davemloft.net> (raw)
In-Reply-To: <Pine.SOC.4.61.0502151230350.2239@math.ut.ee>

On Tue, 15 Feb 2005 08:02:21 -0800
"David S. Miller" <davem@davemloft.net> wrote:

> On Tue, 15 Feb 2005 12:33:15 +0200 (EET)
> Meelis Roos <mroos@linux.ee> wrote:
> 
> > I have cg3 and cg6 framebuffers in my SS5. Current snapshot kernel makes 
> > both work well for fb console (haven't tried X). There is only one 
> > strange thing left - console blanking.
> > 
> > Both cg3 and cg6 behave the same: when it's blanking time, cursor is 
> > turned off but all the text stays. When I press a key to unblank, the 
> > cursor appears again and start flashing like usual.
> 
> Put some debugging printk()'s into drivers/video/cg3.c:cg3_blank() to
> see if it's actually getting called and programming the registers.

Actually I spotted the cg3 problem already.  You'll need to add some
debugging to the cg6 case as I can't find any problems with the blanking
code there.  If the cg6 is not the primary console, probably the blank
function simply isn't being invoked.

Anyways, here is the cg3 fix:

=== drivers/video/cg3.c 1.16 vs edited ==--- 1.16/drivers/video/cg3.c	2005-02-11 23:26:17 -08:00
+++ edited/drivers/video/cg3.c	2005-02-15 07:36:43 -08:00
@@ -209,7 +209,7 @@
 	case FB_BLANK_HSYNC_SUSPEND: /* VESA blank (hsync off) */
 	case FB_BLANK_POWERDOWN: /* Poweroff */
 		val = sbus_readb(&regs->control);
-		val |= CG3_CR_ENABLE_VIDEO;
+		val &= ~CG3_CR_ENABLE_VIDEO;
 		sbus_writeb(val, &regs->control);
 		par->flags |= CG3_FLAG_BLANKED;
 		break;

  parent reply	other threads:[~2005-02-15 16:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-15 10:33 framebuffer blanking Meelis Roos
2005-02-15 16:02 ` David S. Miller
2005-02-15 16:10 ` David S. Miller [this message]
2005-02-16  6:48 ` Meelis Roos
2005-02-16  7:34 ` Meelis Roos
2005-02-16 13:29 ` Meelis Roos
2005-02-16 15:50 ` David S. Miller
2005-02-16 16:03 ` Meelis Roos
2005-02-16 17:14 ` Meelis Roos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050215081032.40d34b45.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.