From: Christoph Hellwig <hch@infradead.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning
Date: Tue, 15 Feb 2005 10:38:46 +0000 [thread overview]
Message-ID: <20050215103846.GA19930@infradead.org> (raw)
In-Reply-To: <42113C2C.17871.52BDF2@localhost>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Tue, Feb 15, 2005 at 08:42:55AM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> On 14 Feb 2005 at 17:15, Dave Jones wrote:
>
> > On Tue, Feb 15, 2005 at 12:02:52AM +0200, Stephen Biggs wrote:
> > Content-Description: Mail message body
> > > Description: compile warning cleanup - silence compiler warning for
> > > unused function that is either actually used as a driver function in a
> > > table or is truly unused
> > >
> > > +++ linux-2.6.11-rc3-mm2/drivers/net/ibmlana.c 2005-02-12 17:22:13.000000000 +0200
> > > @@ -901,7 +901,7 @@ static void ibmlana_set_multicast_list(s
> > >
> > > static int startslot; /* counts through slots when probing multiple devices */
> > >
> > > -static int ibmlana_probe(struct net_device *dev)
> > > +static int __attribute__((unused)) ibmlana_probe(struct net_device *dev)
> >
> > It's called in init_module(). I guess you only tried this in the built-in case ?
>
> It compiles both with allyesconfig and allmodconfig. The "unused"
> attribute is a better solution than #ifdef MODULE.
It's not. It's a big mess.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-02-15 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning cleanup Stephen Biggs
2005-02-14 22:15 ` [KJ] [PATCH][RESUBMIT][9/21] drivers/net/* - compile warning Dave Jones
2005-02-15 6:42 ` Stephen Biggs
2005-02-15 10:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215103846.GA19930@infradead.org \
--to=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.