From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Stephen Evanchik <evanchsa@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH 2.6.11-rc4]: IBM TrackPoint configuration support
Date: Tue, 15 Feb 2005 15:16:18 +0100 [thread overview]
Message-ID: <20050215141618.GC8119@ucw.cz> (raw)
In-Reply-To: <200502132031.02214.dtor_core@ameritech.net>
On Sun, Feb 13, 2005 at 08:31:01PM -0500, Dmitry Torokhov wrote:
> On Sunday 13 February 2005 19:32, Stephen Evanchik wrote:
> > Here is the latest IBM TrackPoint patch. I believe I made all of the
> > necessary changes in this release including the removal of the
> > middle-to-scroll functionality. One item I didn't address was a
> > comment about checking the return code of ps2_command ..
> >
> > I looked at other usages and it wasn't clear to me how to actually
> > implement something that is sane. In some places an error causes a
> > return out of the function and in others the return value is ignored.
> > Should I check each return value or the first ?
>
> I would check all 3 ps2_command calls in trackpoint_init and leave
> the rest as is.
>
> One more thing - I'd like to see more descriptive names of sysfs
> attributes, for example I'd change "ptson" to "press_to_select",
> "mb" to "middle_btn", etc.
Stephen, if you fix the above, and send me the patch, I'll merge it,
there isn't any other problem with it.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-02-15 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 0:32 PATCH 2.6.11-rc4]: IBM TrackPoint configuration support Stephen Evanchik
2005-02-14 1:31 ` Dmitry Torokhov
2005-02-15 14:16 ` Vojtech Pavlik [this message]
2005-02-16 4:13 ` Stephen Evanchik
2005-02-16 5:20 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050215141618.GC8119@ucw.cz \
--to=vojtech@suse.cz \
--cc=dtor_core@ameritech.net \
--cc=evanchsa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.