From: Alex Zarochentsev <zam@namesys.com>
To: Tom Evans <tom@23palmer.net>
Cc: reiserfs-list@namesys.com
Subject: Re: Bitmap alignment issues....
Date: Wed, 16 Feb 2005 07:55:40 +0300 [thread overview]
Message-ID: <20050216045540.GX7482@backtop.namesys.com> (raw)
In-Reply-To: <3pan5q$2kae4@smtp04.mrf.mail.rcn.net>
On Tue, Feb 15, 2005 at 04:37:29PM -0500, Tom Evans wrote:
>
> >do you see aligment faults in the bitmap code after my patch?
>
> The patch that was presented a few days ago caused corruption of the volume.
> I used a "patch" I did that simply used the unaligned macros.
did you apply the patch (see below) which i sent to amd64 guys?
--------------------------------------------------
diff -Nru a/plugin/space/bitmap.c b/plugin/space/bitmap.c
--- a/plugin/space/bitmap.c Wed Feb 16 07:53:36 2005
+++ b/plugin/space/bitmap.c Wed Feb 16 07:53:36 2005
@@ -165,7 +165,7 @@
static int
find_next_zero_bit_in_word(ulong_t word, int start_bit)
{
- ulong_t mask = 1 << start_bit;
+ ulong_t mask = 1UL << start_bit;
int i = start_bit;
while ((word & mask) != 0) {
@@ -235,7 +235,7 @@
assert ("zam-965", start_bit < BITS_PER_LONG);
assert ("zam-966", start_bit >= 0);
- bit_mask = (1 << nr);
+ bit_mask = (1UL << nr);
while (bit_mask != 0) {
if (bit_mask & word)
--------------------------------------------------
>
> I will try the new patch this evening.
>
> Thanks,
>
> ...tom
>
--
Alex.
prev parent reply other threads:[~2005-02-16 4:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 17:59 Bitmap alignment issues Tom Evans
2005-02-09 18:19 ` Alex Zarochentsev
2005-02-10 5:10 ` Thomas Evans
2005-02-10 8:40 ` Alex Zarochentsev
2005-02-10 15:29 ` Tom Evans
2005-02-15 18:30 ` Alex Zarochentsev
2005-02-15 21:37 ` Tom Evans
2005-02-16 4:55 ` Alex Zarochentsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050216045540.GX7482@backtop.namesys.com \
--to=zam@namesys.com \
--cc=reiserfs-list@namesys.com \
--cc=tom@23palmer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.