From: "David S. Miller" <davem@davemloft.net>
To: Matt Mackall <mpm@selenic.com>
Cc: jmoyer@redhat.com, netdev@oss.sgi.com
Subject: Re: serious netpoll bug w/NAPI
Date: Wed, 16 Feb 2005 15:54:07 -0800 [thread overview]
Message-ID: <20050216155407.3dbcd9d6.davem@davemloft.net> (raw)
In-Reply-To: <20050216234406.GA3120@waste.org>
On Wed, 16 Feb 2005 15:44:06 -0800
Matt Mackall <mpm@selenic.com> wrote:
> Ok. We've got a few cases:
>
> 1) recursion on cpu1
If you hit this case, and therefore can't re-enter into ->poll(),
you must drop the packet or so something else if netif_queue_stopped()
since netpoll has no means by which to cause the TX queue to make
forward progress.
Do you at least agree with this?
Perhaps you can create a "pending netpoll() packet" queue so that
you don't have to drop the SKB in this case. Make the queue get
processed via softint processing. I think this will work.
next prev parent reply other threads:[~2005-02-16 23:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 4:16 serious netpoll bug w/NAPI David S. Miller
2005-02-09 18:32 ` Matt Mackall
2005-02-10 0:46 ` David S. Miller
2005-02-10 1:11 ` Matt Mackall
2005-02-10 9:16 ` Martin Josefsson
2005-02-10 17:14 ` Matt Mackall
2005-02-15 22:49 ` Jeff Moyer
2005-02-16 5:07 ` Matt Mackall
2005-02-16 19:26 ` Jeff Moyer
2005-02-16 22:07 ` Jeff Moyer
2005-02-16 23:02 ` David S. Miller
2005-02-16 23:44 ` Matt Mackall
2005-02-16 23:54 ` David S. Miller [this message]
2005-02-17 0:15 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050216155407.3dbcd9d6.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmoyer@redhat.com \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.