From: Matt Porter <mporter@kernel.crashing.org>
To: "Andre' Draszik" <andid@gmx.net>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup
Date: Thu, 17 Feb 2005 10:35:27 -0700 [thread overview]
Message-ID: <20050217103527.A5230@cox.net> (raw)
In-Reply-To: <4213F112.2060606@gmx.net>; from andid@gmx.net on Thu, Feb 17, 2005 at 02:19:14AM +0100
On Thu, Feb 17, 2005 at 02:19:14AM +0100, Andre' Draszik wrote:
> Hi,
>
> Matt Porter wrote:
> > On Mon, Feb 07, 2005 at 05:24:55AM +0100, Andre' Draszik wrote:
> >
> >>Hi,
> >>
> >>this is a rewrite of the ibm4xx ocp ide driver. In its current state it
> >>[...]
> >
> > I tried applying this to current linuxppc-2.5. All hunks are rejected.
> > Can you double check this patch and resend?
>
> my kernel tree is
> rsync -avz --delete source.mvista.com::linuxppc-2.5 linuxppc-2.5
> and as of 16.02.05 23:44GMT the patch still applies. so did i really
> send a wrong patch or has the rsync mirror just not yet been
> updated? or is it a whitespace issue?
>
> just checked - it's the last, so here's the patch, rediffed to
> 2.6.11-rc4, as attachment, not inline this time.
>
> hope it works...
Ok, this one looks good save a few minor things that need done:
1) Rename from ibm_ocp_ide.[c|h] to ibm_stb_ide.[c|h] We want
rid of "ocp" in the file names since eventually 4xx will
convert to platform devices.
2) Remove the #if 0'ed code...if it's not used it doesn't belong
in there.
3) Run Lindent on the driver.
What systems have you tested on?
-Matt
next prev parent reply other threads:[~2005-02-17 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-07 4:24 [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup Andre' Draszik
2005-02-16 23:14 ` Matt Porter
2005-02-17 1:19 ` Andre' Draszik
2005-02-17 1:43 ` Matt Porter
2005-02-17 17:35 ` Matt Porter [this message]
2005-02-19 9:28 ` Andre' Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050217103527.A5230@cox.net \
--to=mporter@kernel.crashing.org \
--cc=andid@gmx.net \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.