From: Parag Warudkar <kernel-stuff@comcast.net>
To: Jody McIntyre <scjody@modernduck.com>
Cc: Dan Dennedy <dan@dennedy.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Linux1394-Devel <linux1394-devel@lists.sourceforge.net>
Subject: Re: [PATCH] ohci1394: dma_pool_destroy while in_atomic() && irqs_disabled()
Date: Sat, 19 Feb 2005 10:06:20 -0500 [thread overview]
Message-ID: <200502191006.21076.kernel-stuff@comcast.net> (raw)
In-Reply-To: <20050219063632.GE9231@conscoop.ottawa.on.ca>
On Saturday 19 February 2005 01:36 am, Jody McIntyre wrote:
> I disagree because the impact of this bug is small. How often do you start
> an ISO receive? If you think it needs to be fixed urgently, please
> explain why - maybe I'm just missing somethnig.
>
I have to agree that the impact is small even for the people using ISO recv -
I happen to use it quite frequently and it hasn't locked up on me yet. So I
certainly don't need it fixed atm. It's just the "dmesg annoyance" if you
will, to deal with :) !
> I'm not sure, but I looked through the code and it seems to allocate:
> - 16 buffers of 2x PAGE_SIZE (= 131072 on i386)
> - 16 buffers of PAGE_SIZE (= 65536 on i386)
> - various other smaller structures.
OTOH, if it allocates so much of memory while irqs disabled and holding locks,
isn't there a good chance for the allocator to sleep and things to go wrong?
Parag
next prev parent reply other threads:[~2005-02-19 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-30 20:54 [PATCH] ohci1394: dma_pool_destroy while in_atomic() && irqs_disabled() Parag Warudkar
2005-01-30 21:17 ` Andrew Morton
2005-01-30 22:49 ` Parag Warudkar
2005-01-30 23:02 ` Andrew Morton
2005-01-31 1:19 ` Parag Warudkar
2005-01-31 23:26 ` Parag Warudkar
2005-02-11 15:35 ` Dan Dennedy
2005-02-11 18:43 ` Jody McIntyre
2005-02-12 3:54 ` Parag Warudkar
2005-02-18 15:32 ` Dan Dennedy
2005-02-18 15:42 ` Parag Warudkar
2005-02-19 6:36 ` Jody McIntyre
2005-02-19 15:06 ` Parag Warudkar [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-19 19:36 David Brownell
2005-02-19 20:50 ` Parag Warudkar
2005-02-19 21:13 ` David Brownell
2005-02-19 22:55 ` Jody McIntyre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502191006.21076.kernel-stuff@comcast.net \
--to=kernel-stuff@comcast.net \
--cc=akpm@osdl.org \
--cc=dan@dennedy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@modernduck.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.